733 default to past tab when all questions are closed #734

camilovegag · 2024-08-05T13:48:20Z

Closes: #733

Defaults to past tab when no openCycles

Evidence:

Summary by CodeRabbit

New Features
- Enhanced the TabsHeader component to accept an activeTab prop for better control from parent components.
- Introduced a new Questions component for improved tab state management and rendering.
- Implemented dynamic active tab management in the Event page based on the state of openCycles, improving user navigation according to available data.
Bug Fixes
- Ensured that unnecessary updates are avoided by updating the active tab only when a different tab is clicked.

vercel · 2024-08-05T13:48:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
forum-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 6, 2024 2:12pm

coderabbitai · 2024-08-05T13:48:29Z

Walkthrough

The updates to the TabsHeader and Event components enhance state management by adopting a controlled component model for tab navigation. The initialTab prop is replaced with activeTab, improving synchronization with the tab's state. Additionally, the new Questions component dynamically determines the active tab based on openCycles, enhancing responsiveness and user experience when questions are closed.

Changes

File	Change Summary
`.../tabs/TabsHeader.tsx`	Replaced `initialTab` with `activeTab`, removed internal state management, and refined tab click handling.
`.../Event.tsx`	Introduced `Questions` component with `useMemo` for dynamic `activeTab`; updated `TabsHeader` to accept `activeTab`.

Assessment against linked issues

Objective	Addressed	Explanation
Default to past tab when all questions are closed (#733)	✅

Poem

In the land of tabs, where bunnies play,
A click brings joy, come what may.
With past and upcoming, we leap with cheer,
The right tab shows, our path is clear!
Hopping through code, we dance and code,
Reusable magic on this happy road! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f958775 and d5cae6e.

Files selected for processing (2)

packages/berlin/src/components/tabs/TabsHeader.tsx (1 hunks)
packages/berlin/src/pages/Event.tsx (3 hunks)

Additional comments not posted (2)

packages/berlin/src/components/tabs/TabsHeader.tsx (1)

1-7: LGTM! But verify the function usage in the codebase.

The changes to the TabsHeader component are approved. The shift from initialTab to activeTab and the controlled component pattern is a good practice.

However, ensure that all instances of TabsHeader in the codebase have been updated to use the new activeTab prop.

packages/berlin/src/pages/Event.tsx (1)

50-57: LGTM! But verify the function usage in the codebase.

The changes to the Event component are approved. The addition of the useEffect hook to dynamically set the activeTab based on the state of openCycles is a good enhancement.

However, ensure that all instances of Tabs.TabsHeader in the codebase have been updated to use the new activeTab prop.

packages/berlin/src/components/tabs/TabsHeader.tsx

diegoalzate · 2024-08-05T14:30:23Z

packages/berlin/src/pages/Event.tsx

+  useEffect(() => {
+    if (!openCycles || openCycles.length === 0) {
+      setActiveTab('past');
+    } else {
+      setActiveTab('upcoming');
+    }
+  }, [openCycles]);


this can be done in a different way, maybe just a function that returns 'past' | 'upcoming' and the result is passed as a prop

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d5cae6e and 6e8362e.

Files selected for processing (2)

packages/berlin/src/components/tabs/TabsHeader.tsx (2 hunks)
packages/berlin/src/pages/Event.tsx (4 hunks)

Files skipped from review as they are similar to previous changes (2)

packages/berlin/src/components/tabs/TabsHeader.tsx
packages/berlin/src/pages/Event.tsx

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6e8362e and 4d08f6b.

Files selected for processing (2)

packages/berlin/src/components/tabs/TabsHeader.tsx (1 hunks)
packages/berlin/src/pages/Event.tsx (3 hunks)

Files skipped from review as they are similar to previous changes (1)

packages/berlin/src/components/tabs/TabsHeader.tsx

Additional comments not posted (5)

packages/berlin/src/pages/Event.tsx (5)

7-7: Import statement for GetCycleResponse looks good.

The import is necessary for type definitions used in the getInitialTab function.

47-48: Initialization of activeTab using getInitialTab looks good.

This change ensures the activeTab is dynamically set based on the presence of openCycles.

50-50: Definition of tabNames looks good.

This array defines the possible tab names.

51-53: Introduction of getInitialTab function looks good.

This function determines the initial tab based on the presence and length of openCycles.

93-93: Update to Tabs.TabsHeader component looks good.

This change ensures the tab header accurately reflects the current active tab.

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4d08f6b and d903c0d.

Files selected for processing (1)

packages/berlin/src/pages/Event.tsx (4 hunks)

Additional context used

GitHub Check: Check linting

packages/berlin/src/pages/Event.tsx

[failure] 7-7:
'GetCycleResponse' is defined but never used. Allowed unused vars must match /^_ignored/u

Additional comments not posted (2)

packages/berlin/src/pages/Event.tsx (2)
96-118: LGTM!

The implementation of the Questions component is correct and well-integrated with the Tabs components.

47-51: LGTM! Verify the usage of initialTab.

The use of useMemo for computing initialTab is appropriate and the logic is correct.

However, ensure that the initialTab is correctly used throughout the codebase.

Verification successful

The usage of initialTab is correct.

The initialTab is consistently used within the component and passed correctly to child components.

initialTab is defined using useMemo.

It is passed as a prop to the Questions component.

It is used to initialize the state with useState.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the usage of `initialTab` in the codebase.

# Test: Search for the usage of `initialTab`. Expect: Correct usage in all instances.
rg --type tsx -A 5 $'initialTab'
Length of output: 59

Script:
#!/bin/bash
# Description: Verify the usage of `initialTab` in the codebase.

# Find all .tsx files and search for the usage of `initialTab`
fd -e tsx -x rg 'initialTab' {}
Length of output: 262

packages/berlin/src/pages/Event.tsx

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d903c0d and dec4c67.

Files selected for processing (1)

packages/berlin/src/pages/Event.tsx (3 hunks)

Files skipped from review as they are similar to previous changes (1)

packages/berlin/src/pages/Event.tsx

…s-are-closed

packages/berlin/src/components/tabs/TabsHeader.tsx

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dec4c67 and c18bab3.

Files selected for processing (1)

packages/berlin/src/pages/Event.tsx (3 hunks)

Files skipped from review as they are similar to previous changes (1)

packages/berlin/src/pages/Event.tsx

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c18bab3 and 006c1fd.

Files selected for processing (1)

packages/berlin/src/pages/Event.tsx (3 hunks)

Files skipped from review as they are similar to previous changes (1)

packages/berlin/src/pages/Event.tsx

camilovegag added 2 commits August 5, 2024 08:46

Remove internal state from tabs header

0cd32e7

Add useEffect to handle empty openCycles

d5cae6e

camilovegag requested a review from diegoalzate August 5, 2024 13:48

camilovegag requested a review from MartinBenediktBusch August 5, 2024 13:48

camilovegag self-assigned this Aug 5, 2024

camilovegag linked an issue Aug 5, 2024 that may be closed by this pull request

Default to past tab when all questions are closed #733

Closed

camilovegag added the improvement Improvement of an existing feature label Aug 5, 2024

coderabbitai bot reviewed Aug 5, 2024

View reviewed changes

MartinBenediktBusch approved these changes Aug 5, 2024

View reviewed changes

diegoalzate suggested changes Aug 5, 2024

View reviewed changes

camilovegag added 2 commits August 5, 2024 17:41

Change prop to initial tab and remove extra if

22f0f2c

Set active tab after openCycles response, removing unwanted useEffect

6e8362e

vercel bot deployed to Preview August 5, 2024 22:43 View deployment

coderabbitai bot reviewed Aug 5, 2024

View reviewed changes

simplify state

4d08f6b

vercel bot deployed to Preview August 6, 2024 08:52 View deployment

coderabbitai bot reviewed Aug 6, 2024

View reviewed changes

wip: add sepearte section for question tabs

fdb940e

vercel bot deployed to Preview August 6, 2024 09:43 View deployment

remove not needed function

d903c0d

vercel bot deployed to Preview August 6, 2024 09:45 View deployment

coderabbitai bot reviewed Aug 6, 2024

View reviewed changes

packages/berlin/src/pages/Event.tsx Show resolved Hide resolved

fix linting

dec4c67

coderabbitai bot reviewed Aug 6, 2024

View reviewed changes

vercel bot deployed to Preview August 6, 2024 10:37 View deployment

diegoalzate added 2 commits August 6, 2024 14:37

Merge branch 'develop' into 733-default-to-past-tab-when-all-question…

a526094

…s-are-closed

move tabs so they can modify the activetab state in questions

c18bab3

diegoalzate approved these changes Aug 6, 2024

View reviewed changes

packages/berlin/src/components/tabs/TabsHeader.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview August 6, 2024 13:43 View deployment

coderabbitai bot reviewed Aug 6, 2024

View reviewed changes

Fix grid

006c1fd

vercel bot deployed to Preview August 6, 2024 14:12 View deployment

coderabbitai bot reviewed Aug 6, 2024

View reviewed changes

camilovegag merged commit 619180c into develop Aug 6, 2024
4 checks passed

camilovegag deleted the 733-default-to-past-tab-when-all-questions-are-closed branch August 6, 2024 14:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

733 default to past tab when all questions are closed #734

733 default to past tab when all questions are closed #734

camilovegag commented Aug 5, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Aug 5, 2024 •

edited

Loading

coderabbitai bot commented Aug 5, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

diegoalzate Aug 5, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

733 default to past tab when all questions are closed #734

733 default to past tab when all questions are closed #734

Conversation

camilovegag commented Aug 5, 2024 • edited by coderabbitai bot Loading

Closes: #733

Evidence:

Summary by CodeRabbit

vercel bot commented Aug 5, 2024 • edited Loading

coderabbitai bot commented Aug 5, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

diegoalzate Aug 5, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

camilovegag commented Aug 5, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Aug 5, 2024 •

edited

Loading

coderabbitai bot commented Aug 5, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)